Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_microarch: require x86_64-v3 for RHEL10 #1196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichalHe
Copy link
Member

@MichalHe MichalHe commented Apr 4, 2024

This patch extends the microarchitecture checks to require x86_64-v3 CPU features when upgrading to RHEL10. The list of flags has been compiled based on the x86_64-v3 ABI description found here. The ABI CPU features were then translated to the corresponding names used by Linux kernel as found in cpufeatures.h.

I have verified that the list of should be correct by making sure that the upgrade will not be inhibited on my relatively new CPU (i.e. my CPU has all the required flags).

Copy link

github-actions bot commented Apr 4, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42
Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@MichalHe MichalHe force-pushed the x86_64-v3 branch 2 times, most recently from 249af27 to de6f1d1 Compare April 4, 2024 13:10
@MichalHe MichalHe changed the title check_microarch: refactor to handle possible future reqs check_microarch: require x86_64-v3 for RHEL10 Aug 28, 2024
@MichalHe MichalHe marked this pull request as ready for review August 28, 2024 10:51
Comment on lines +51 to +63
rhel9_microarch_article = reporting.ExternalLink(
title='Building Red Hat Enterprise Linux 9 for the x86-64-v2 microarchitecture level',
url='https://red.ht/rhel-9-intel-microarchitectures'
)

rhel_major_to_microarch_reqs = {
'9': MicroarchInfo(microarch_ver='x86-64-v2',
required_flags=(X86_64_BASELINE_FLAGS + X86_64_V2_FLAGS),
extra_report_fields=[rhel9_microarch_article]),
'10': MicroarchInfo(microarch_ver='x86-64-v3',
required_flags=(X86_64_BASELINE_FLAGS + X86_64_V2_FLAGS + X86_64_V3_FLAGS),
extra_report_fields=[]),
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a note to the OAMG-11275 ticket to not forget to implement the shortened URL when a documentation is created.

Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. keeping unmerged for now to test it manually yet.

@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants